[CVE-2026-98688][MODERATE REGULAR] thunderbolt: Fix NULL dereference in tb_remove_work()

[CVE-2026-98688][MODERATE REGULAR] thunderbolt: Fix NULL dereference in tb_remove_work()

[AL-KERNEL]

CVE: CVE-2026-98688
Priority: MODERATE REGULAR
AL-KERNEL base severity: MODERATE
KPANIC flag: NO
Patch: thunderbolt: Fix NULL dereference in tb_remove_work()
Commit: 2f4cd43faa9d6470b30a9fbcbac6584db8108c1f
Upstream patch: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=2f4cd43faa9d6470b30a9fbcbac6584db8108c1f
Original CVE announcement: https://lore.kernel.org/linux-cve-announce/?q=CVE-2026-98688
Analysis date: Fri, 23 Oct 2026 19:56:52 -0400
ActionableScore: 0
ActionableScore lower bound: unknown
Actionable bucket: Ordinary Moderate
Manual review required: NO

Summary:
A narrow Thunderbolt teardown race can pass a cleared NULL root switch to XDomain cleanup and crash the kernel, but it does not establish UAF, memory corruption, authorization bypass, or privilege escalation.

======================================================================
ABOUT THIS REPORT
======================================================================

The original Linux kernel CVE announcement for CVE-2026-98688 is available here:
https://lore.kernel.org/linux-cve-announce/?q=CVE-2026-98688

The original announcement does not normally provide a security severity
estimate, CVSS assessment, or enough information to determine whether the
reported kernel bug represents a practically relevant security issue.

This report was generated by AL-KERNEL, an AI-assisted Linux kernel
vulnerability analysis system developed by Alexander Larkin. It combines
an autonomous classifier with LLM-assisted technical analysis and a
separate ActionableScore mechanism.

The purpose of this report is to prioritize Linux kernel CVEs before
manual review, identify cases that require prompt investigation, and
support automatic closure of issues that are unlikely to have meaningful
security impact.

Published priority for this report: MODERATE REGULAR
Manual review required: NO

A detailed explanation of the methodology and priority rules is included
at the end of this message.

======================================================================
AL-KERNEL CLASSIFICATION RESULT
======================================================================

CVE-2026-98688	MODERATE	https://www.kernelcve.org/list/?q=CVE-2026-98688 CHECK WITH IMPACT FROM ORIG NN MODERATE | AEGIS IMPACT MODERATE_KPANIC AEGIS_AS=1 LEGACY=MODERATE RESULT=DIFF V39_AEGIS_ONE_STEP_UP=LOW->MODERATE TEMP_DISTANCE_MERGE_SKIP=AEGIS_NO_POSITIVE_SEVERITY_EVIDENCE (final Legacy and Aegis differ; FINAL: MODERATE, Aegis: MODERATE_KPANIC)	Maybe valid. Check manually. Hints by AL-KERNEL: The best (paranoid) CVSS is 'AV:P/AC:H/PR:N/UI:N/S:U/C:N/I:N/A:H';CWE-362;**CWE-476;CWE-667;BEST CVSS score: '4.2';DESCR 'A race between tb_remove_work and tb_domain_remove can leave tb_remove_work running after the Thunderbolt domain teardown has removed the root switch and set tb root_switch to NULL. The running callback can then pass the NULL pointer to tb_free_unplugged_xdomains and cause a kernel Oops or panic. A practical unprivileged trigger is associated with physical Thunderbolt device removal while the delayed removal callback is running. For the CVSS the PR:N value is used because a physical attacker does not need an account or existing privileges on the target system. AV:P reflects the need for physical access to the Thunderbolt fabric and AC:H reflects the narrow race window. Impact is denial of service through a kernel crash. The available code does not provide a UAF OOB access information leak or controlled memory corruption primitive that would support confidentiality integrity or privilege escalation impact. Automated impact decision path. The original SimpleNet classifier selected MODERATE_KPANIC. The primary LLM estimated paranoid CVSS 4.2 and the production ActionableScore returned 0 with recommendation Ordinary Moderate. The production rules then evaluated CVSS thresholds and ActionableScore thresholds. Recorded rule transitions were CVSS and initial triage stage MODERATE_KPANIC to MODERATE because the CVSS score, vector or bug class threshold rule was applied. ActionableScore thresholds stage MODERATE to LOW because the ActionableScore threshold rule was applied. final reconciliation stage LOW to MODERATE because KP specialist did not establish a qualifying panic and the cross model evidence reconciliation rule was applied. The legacy KP specialist has no review artifact for this run. The legacy FD or DH downgrade specialist has no review artifact for this run. Exact triggered rule markers were DECREASED_TO_MODERATE_REGULAR_FROM_MODERATE7_BASED_ON_GUESSCVSS and DECREASED_TO_LOW_FROM_MODERATE_BASED_ON_ACTIONABLESCORELESSTHAN3 and KPANIC_UNSUPPORTED_REMOVED and V39_AEGIS_ONE_STEP_UP and MANUAL_REVIEW_REQUIRED. The independent weaker Aegis shadow evaluated CVSS 2.0 and ActionableScore 1 with primitive class CLASS_C and manual review REQUIRED. Its independently reconciled impact was MODERATE_KPANIC. Cross model aggregation changed the production result under an enabled evidence gated merge rule. The final reported impact is MODERATE.';YES REQUIRES MANUAL CHECK; ,and ActionableScore result is Ordinary Moderate (with actual score 0)	MAYBE	NULLPTR INIT RACE HARDWARE DECREASED_TO_MODERATE_REGULAR_FROM_MODERATE7_BASED_ON_GUESSCVSS DECREASED_TO_LOW_FROM_MODERATE_BASED_ON_ACTIONABLESCORELESSTHAN3 KPANIC_UNSUPPORTED_REMOVED V39_AEGIS_ONE_STEP_UP MANUAL_REVIEW_REQUIRED	-	-	checked

======================================================================
ACTIONABLESCORE ANALYSIS
======================================================================

ActionableScore=0
PrimitiveClass=CLASS_C
RealUAF=NO
HostAdminRequired=NO
NamespaceScopedPrivilege=NO
ImportantCandidate=NO
ManualReview=NO
AutoDowngradeAllowed=YES
RequiresHostUID0=NO
AuthorizationDecisionBypass=NO
ProtectedResourceImpact=NONE
B4PendingReview=NO
B4PendingConfirmed=NO

1. ActionableScore

* Raw conservative score: 0
* Conservative score: 0
* Raw paranoid score: 0
* Paranoid score: 0
* Final recommended bucket: **Ordinary Moderate**::

No floor or cap was applied.

2. Signal breakdown

* +1 Reliable kernel crash / strong DoS. The NULL `root_switch` is passed to `tb_free_unplugged_xdomains()`, supporting a kernel Oops and possible panic.
* -1 Hard race. The vulnerable ordering requires `tb_remove_work()` to remain active while the one-shot Thunderbolt domain teardown clears `tb->root_switch`.
* No UAF points. The `struct tb` and work item remain alive. The invalid value is a deliberately cleared NULL pointer, not a freed or reclaimed object.
* No corruption points. There is no OOB access, post-free write, repeated release, refcount mutation, controlled overwrite, or active-state corruption.
* No additional availability point. It would duplicate the same NULL-dereference crash.
* No C/I, LPE, authorization, V32, V33, B3, B4, or B5-R signal is established.
* No physical-hardware penalty was separately applied because it would substantially duplicate the already constrained physical teardown and timing conditions.

3. Reachability analysis

A physical actor may attempt to induce the ordering by removing a Thunderbolt device or domain while delayed removal work is running. This path needs no host account, UID 0, or namespace capability, so `HostAdminRequired=NO` for that physical attacker model. A software-triggered controller unbind or driver removal would normally require host administration, but that is a separate trigger model.

Thunderbolt hardware and an active domain are prerequisites. The operation is not namespace-scoped, remotely network-triggerable, or reachable through ordinary packet traffic. The race is narrow and tied to teardown, with no evidence that an attacker can deterministically control the interleaving.

4. Primitive and severity interpretation

The exact primitive is a race-induced NULL-pointer dereference. It is not stale storage or an active structured-object UAF because no object is shown to outlive its allocation lifetime. No concrete repeated release or refcount operation exists.

This is `CLASS_C`: the demonstrated result is invalid-state consumption followed by an Oops or panic. Theoretical memory reuse, privilege escalation, confidentiality loss, and integrity modification are unsupported. `ImportantCandidate=NO` and `AutoDowngradeAllowed=YES` because no independently useful corruption or trust-boundary primitive remains after excluding the crash.

5. One-sentence report phrase

A narrow Thunderbolt teardown race can pass a cleared NULL root switch to XDomain cleanup and crash the kernel, but it does not establish UAF, memory corruption, authorization bypass, or privilege escalation.

6. Manual review recommendation

NO MANUAL CHECK NEEDED

The patch establishes a constrained physical teardown race with crash-only impact and no unresolved corruption or security-boundary primitive.

7. Call-site confidence

Call-site confidence: high

======================================================================
UPSTREAM PATCH SUMMARY
======================================================================

Patch: thunderbolt: Fix NULL dereference in tb_remove_work()
Commit: 2f4cd43faa9d6470b30a9fbcbac6584db8108c1f
Upstream URL: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=2f4cd43faa9d6470b30a9fbcbac6584db8108c1f

Commit description:

There is a slight race between tb_remove_work() and tb_domain_remove()
which leads to dereferencing a NULL tb->root_switch pointer inside
tb_free_unplugged_xdomains():

        Thread A                            Thread B

  tb_remove_work()
                                    tb_domain_remove()
                                      mutex_lock(&tb->lock)
                                      tb_stop()
                                        /* doesn't cancel a running callback */
                                        cancel_delayed_work(&tcm->remove_work)
                                        ...
                                        tb_switch_remove(tb->root_switch)
                                        tb->root_switch = NULL
                                      mutex_unlock(&tb->lock)
    mutex_lock(&tb->lock)
    ...
    /* without checking ->root_switch */
    tb_free_unplugged_xdomains(tb->root_switch)
    mutex_unlock(&tb->lock)

Commit a8937f3 ("thunderbolt: Remove XDomain from the bus without
holding tb->lock") doesn't seem right to move tb_free_unplugged_xdomains()
out of the &tb->lock section and the check for tb->root_switch, in
particular.  It states:

  For this reason separate removing the XDomain from the topology data
  structures (where we need the lock) from unregistering the device from
  the bus (where remove callbacks of the drivers are being called).

tb_free_unplugged_xdomains() belongs to the former group of functions
requiring the lock.  And it also calls tb_xdomain_remove() which should
only be called with &tb->lock held.

Found by Linux Verification Center (linuxtesting.org) with Svace static
analysis tool.

Fixes: a8937f3 ("thunderbolt: Remove XDomain from the bus without holding tb->lock")
Cc: stable@vger.kernel.org
Signed-off-by: Fedor Pchelkin <pchelkin@ispras.ru>
Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Changed files:
  drivers/thunderbolt/tb.c

Diff excerpt:

Not included in this email. See the upstream URL for the full patch.

Full patch:
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=2f4cd43faa9d6470b30a9fbcbac6584db8108c1f

======================================================================
DETAILED REPORT METHODOLOGY
======================================================================

The original Linux kernel CVE announcement for CVE-2026-98688 can be found here:
https://lore.kernel.org/linux-cve-announce/?q=CVE-2026-98688

The original CVE announcement normally does not include a security-level
estimate. In particular, it may not contain a CVSS assessment, an impact
level, or enough information to determine whether the reported bug is a
practically relevant security issue. One purpose of this parallel CVE list
is to provide that missing technical and prioritization information.

The original goal of the AL-KERNEL project was to prioritize Linux kernel
CVE analysis automatically before manual review. The system can also help
identify non-security issues that may be suitable for automatic closure.

This report was generated by AL-KERNEL, an AI-assisted Linux kernel
vulnerability analysis system developed by Alexander Larkin.

The first analysis stage combines an autonomous classifier with additional
LLM-based analysis. The autonomous classifier runs locally on a CPU and is
based on a backpropagation neural network. Together, these mechanisms
produce a technical vulnerability description, identify likely weakness
types, estimate CVSS severity, and provide input for ActionableScore.

Two CVSS estimates are retained because incomplete kernel vulnerability
information often permits more than one defensible interpretation:

  Conservative CVSS vector: Not available
  The Best / paranoid CVSS vector: AV:P/AC:H/PR:N/UI:N/S:U/C:N/I:N/A:H
  The Best / paranoid CVSS score: 4.2

The conservative vector represents a lower-impact interpretation.
The Best/paranoid vector intentionally represents a plausible upper-bound
interpretation and should not automatically be treated as demonstrated
real-world impact.

CVSS may also need to be adjusted for a particular Linux deployment,
because actual reachability, privileges, enabled kernel configuration,
hardware, namespaces, exposed device nodes, and other environmental
conditions can differ significantly between systems.

A separate ActionableScore mechanism evaluates practical remediation
urgency. Its analysis may include reachability, attack prerequisites,
subsystem exposure, memory-corruption characteristics, denial-of-service
reliability, and possible confidentiality, integrity, or
privilege-escalation impact.

  Conservative ActionableScore: unknown
  Paranoid ActionableScore: 0

The final base severity is taken directly from the second tab-separated
field of the AL-KERNEL classification result. ActionableScore does not
replace or independently override that final AL-KERNEL decision, and
if ActionableScore adjusted impact level of ALKERNEL, then you would see
self-readable flags above like INCREASED_TO_HIGH_BASED_ON_ACTIONABLESCOREHIGHEREQTHAN7.

For an AL-KERNEL result of MODERATE, this report uses the following
additional presentation split:

  ActionableScore below 5   -> MODERATE REGULAR
  ActionableScore 5 or more -> MODERATE 7.0

The distinction between MODERATE REGULAR and MODERATE 7.0 makes it
possible to identify Moderate issues that should receive manual analysis
and fixes before lower-priority MODERATE REGULAR issues. In many cases,
MODERATE REGULAR fixes may wait for a later rebase or routine update.

There is one override in which MODERATE REGULAR becomes MODERATE 7.0
even when the ActionableScore is below 5. When the AL-KERNEL result
contains the KPANIC flag, a MODERATE result is always presented as
MODERATE 7.0. The KPANIC flag selected with few regexps without
usage of AI at all, so it helps to detect cases when Kernel Crash happens
and similar (to filter False-Negative results from the LLM usage).

KPANIC indicates that a reliable kernel crash, kernel panic, or similarly
serious kernel availability impact was identified by the classification
workflow.

AL-KERNEL base severity for this report: MODERATE
KPANIC detected for this report: NO
Published priority for this report (same as in Subject): MODERATE REGULAR

These results are intended to support engineering triage. They are
machine-generated estimates, and cases marked for manual review should
be validated by a human security engineer before final disposition.
For more info read docs linked from here: https://kernelcve.org/
(and you can submit you own patch there to generate such a report
for non-existant CVE-id yet).

Note that in many cases this AI tool selects higher severity, than
real is (means you can expect Importants instead of Moderate 7.0 or
Moderates 7.0 instead of regular Moderates). If you see such cases,
please use reply email interface to add additional manual analyses
info to this particular CVE.
And please, please, let me know when you see Lows instead of Importants
or Important instead of Low (because particular for such cases I
need to tune this AI tool to make it better for this one and next similar).
My contact email for such notifications is alexanjelausa@gmail.com (and both
send reply to CVE record itself too and see "reply" button below for howto reply).